test(exceptions): remove #[CoversClass] from exception test to fix PH…#13
Merged
walmir-silva merged 1 commit intomainfrom Mar 5, 2026
Merged
test(exceptions): remove #[CoversClass] from exception test to fix PH…#13walmir-silva merged 1 commit intomainfrom
walmir-silva merged 1 commit intomainfrom
Conversation
…PUnit 12 CI warning In PHPUnit 12 + pcov, classes that directly extend a native PHP class (\RuntimeException) are reported as 'not a valid target for code coverage'. This generates 4 PHPUnit warnings — one per test method — which with the devkit-generated failOnWarning="true" in phpunit.xml.dist cause exit code 1, blocking the CI pipeline despite 100% coverage and 175 passing tests. Fix: remove #[CoversClass(InvalidRuleException::class)] and #[CoversClass(SanitizationException::class)] from SanitizationExceptionsTest. Coverage for both exception classes is still achieved transitively via SanitizerEngineTest, InMemoryRuleRegistryTest, and integration tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…PUnit 12 CI warning
In PHPUnit 12 + pcov, classes that directly extend a native PHP class (\RuntimeException) are reported as 'not a valid target for code coverage'.
This generates 4 PHPUnit warnings — one per test method — which with the devkit-generated failOnWarning="true" in phpunit.xml.dist cause exit code 1, blocking the CI pipeline despite 100% coverage and 175 passing tests.
Fix: remove #[CoversClass(InvalidRuleException::class)] and #[CoversClass(SanitizationException::class)] from SanitizationExceptionsTest. Coverage for both exception classes is still achieved transitively via SanitizerEngineTest, InMemoryRuleRegistryTest, and integration tests.